Skip to content

DOCSP-32942: Deprecated Methods #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Oct 4, 2023
Merged

DOCSP-32942: Deprecated Methods #446

merged 20 commits into from
Oct 4, 2023

Conversation

norareidy
Copy link
Contributor

@norareidy norareidy commented Sep 22, 2023 •
edited
Loading

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-32942
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/java/docsworker-xlarge/DOCSP-32942-deprecated-methods/whats-new/#what-s-new-in-4.11

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?

jordan-smith721
jordan-smith721 approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@jordan-smith721 jordan-smith721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ one suggestion and a question

norareidy and others added 3 commits September 22, 2023 16:41
@norareidy
review feedback
9a35327
DOCSP-33241: fix extended JSON example id field (mongodb#447)
f4e1889 
* DOCSP-33241: fix extended JSON example id field
DOCSP-31694: SOCKS5 proxy support (mongodb#439)
3d0675c 
* DOCSP-31694: SOCKS5 proxy support
@norareidy norareidy requested review from a team and vbabanin and removed request for a team September 25, 2023 18:26
ccho-mongodb pushed a commit to ccho-mongodb/docs-java that referenced this pull request Sep 25, 2023
fix indentation, identify items replaced by PR mongodb#446
5181c77
vbabanin
vbabanin reviewed Sep 27, 2023
View reviewed changes
@norareidy norareidy requested a review from vbabanin September 29, 2023 16:03
ccho-mongodb
ccho-mongodb approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@ccho-mongodb ccho-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just added a couple suggestions.

@norareidy norareidy merged commit 96156ec into mongodb:master Oct 4, 2023
@norareidy norareidy deleted the DOCSP-32942-deprecated-methods branch October 4, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jordan-smith721 jordan-smith721 jordan-smith721 approved these changes

@vbabanin vbabanin vbabanin approved these changes

+1 more reviewer

@ccho-mongodb ccho-mongodb ccho-mongodb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@norareidy @vbabanin @jordan-smith721 @ccho-mongodb @kyuan-mongodb